Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create environment details are reset when the page loses scope. #241

Open
kcpevey opened this issue Jul 5, 2023 · 6 comments
Open

Create environment details are reset when the page loses scope. #241

kcpevey opened this issue Jul 5, 2023 · 6 comments
Labels
area: UI design 🎨 Items related to the user interface project: JATIC Work item needed for the JATIC project type: enhancement 💅🏼 New feature or request

Comments

@kcpevey
Copy link
Contributor

kcpevey commented Jul 5, 2023

If I start to fill out the "Create" page, then I switch views to an existing environment (to copy some requirements for example), then I switch back to the page where I was creating the new environment, all of my information will be removed/reset.

I expect for the data that I've input to persist as long as my new Create Environment tab is open.

@kcpevey kcpevey added type: enhancement 💅🏼 New feature or request area: UI design 🎨 Items related to the user interface labels Jul 5, 2023
@kcpevey
Copy link
Contributor Author

kcpevey commented Jul 12, 2023

Note that I can switch to another browser tab and back and my information will remain. Its only when switching between the visible conda environment windows (within the conda-store-ui).

Another annoyance - I have an env that's currently building. The default when I view the window is set to view the "Active" env.

image

No problem. If I now switch over to view the "Building" env....

image

Looks good. But then if I view ANOTHER conda env and click back on the original env where I was just viewing "Building"...

image

It has defaulted back to the "Active" env (actually this env failed, but that's a separate issue). As a user this is HIGHLY CONFUSING. I actually wonder how many issues I've submitted based on the incorrect assumption that the UI was as I just left it.

The UI elements really need to persist as they are set as long as the env window is open.

@kcpevey kcpevey added the project: JATIC Work item needed for the JATIC project label Sep 14, 2023
@ericdatakelly
Copy link

Thanks for opening this issue. It's a pain for me too. I was creating an environment that needed a personal access token for a private repo install, but that disappeared after switching to another conda-store tab. Now I have to go figure out that token syntax again.

@kcpevey
Copy link
Contributor Author

kcpevey commented Apr 24, 2024

@ericdatakelly yes, that is a VERY common pain point for me too.

@gabalafou will this be resolved with your work on tabs? Persisting global state (Step 2) will help with switching back and forth, but I think we'll have a decent workflow even after Step 1 since we can open the two environments in separate browser tabs.

@gabalafou
Copy link
Contributor

I think it will be fixed by #394, which is a part of the no tabs story.

@gabalafou
Copy link
Contributor

gabalafou commented May 8, 2024

To follow up on this, I uploaded a draft PR (#400) but I'm thinking that maybe we should first make a release that includes #389 and see if that prevents this bug (and other tab-related bugs) from surfacing. (See my note in the description of #400 for why I think this is how we should proceed.) My thinking is that if there are no tabs, a typical end user no longer has the expectation that the values will persist, and instead have a "load new page" mental model where the slate gets wiped clean with each page navigation. I could be wrong but I'd like to first test the new UI than sink more time into #400.

@kcpevey
Copy link
Contributor Author

kcpevey commented May 8, 2024

@gabalafou I think you might be right on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI design 🎨 Items related to the user interface project: JATIC Work item needed for the JATIC project type: enhancement 💅🏼 New feature or request
Projects
Status: New 🚦
Development

No branches or pull requests

3 participants