Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages around pip packages #504

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Jul 20, 2023

Closes #497

@costrouc costrouc merged commit 081ce5b into main Jul 20, 2023
7 checks passed
@costrouc costrouc deleted the feat-relax-pypi-schema branch July 20, 2023 16:38
@trallard
Copy link
Collaborator

@costrouc you mentioned "better docs" inclusion and error messages in this PR - but I cannot see any docs updates only the schema and validations update. Is this an oversight?

@trallard
Copy link
Collaborator

@costrouc ping here can you please confirm if any docs were updated elsewhere?

@trallard trallard changed the title Better docs and error messages around pip packages Better error messages around pip packages Aug 25, 2023
@costrouc
Copy link
Member Author

@trallard when a user supplies an invalid pypi package name they were before this PR prompted with:

Invalid pypi package dependency {v}

now

Invalid pypi package dependency "{v}" ensure it follows peps https://peps.python.org/pep-0508/ and https://peps.python.org/pep-0440/'.

This error message will show up on conda-store-ui and the legacy conda-store ui as well when an invalid pypi package is added. I was adding a link to the reference docs and providing a better error message.

No conda-store specific docs were updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Enable token authentication to private repos
2 participants