Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository URL #518

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Conversation

steff456
Copy link
Contributor

@steff456 steff456 commented Aug 2, 2023

This PR is part of #514

This PR,

  • Changes url that where pointing to Quansight org and replace it with conda-incubator org.

@steff456 steff456 added the project: JATIC Work item needed for the JATIC project label Aug 2, 2023
@steff456 steff456 added this to the 🚀 JATIC - Q1 milestone Aug 2, 2023
@steff456 steff456 self-assigned this Aug 2, 2023
@steff456 steff456 requested a review from trallard August 2, 2023 16:51
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steff456 thanks for the PR. Should we also update the links in the CHANGELOG.md? Also I see another file https://github.com/conda-incubator/conda-store/blob/main/conda-store-server/conda_store_server/alembic/versions/16f65805dc8f_split_conda_package_into_conda_package_.py#L230 which mentions the Quansight repo.

cc @trallard what are your thoughts about changing bits in the CHANGELOG.md?

@steff456
Copy link
Contributor Author

steff456 commented Aug 2, 2023

I wasn't sure if we were going to modify the changelog, so I'll wait for a reply before doing changes in that file

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that the changelog doesn't change since it can help to show the history of the project. @trallard we can apply these changes later if needed. LGTM. I'll merge.

@costrouc costrouc merged commit e0e15cc into conda-incubator:main Aug 4, 2023
7 of 8 checks passed
@steff456 steff456 deleted the fix-post-migration branch August 4, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: JATIC Work item needed for the JATIC project
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

None yet

2 participants