Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all channels by default #545

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

nkaretnikov
Copy link
Contributor

Fixes #357.

@nkaretnikov
Copy link
Contributor Author

Changed to empty list (allow all), added example that used to be the previous default, verified that this environment is accepted (with the empty list in allowed channels) and builds:

channels:
- conda-forge
- https://repo.anaconda.com/pkgs/main
dependencies:
- pip
- pip:
  - nothing
- ipykernel
description: ''
name: test-env
prefix: null
variables: null

How it now looks in the web UI:

Screen Shot 2023-08-23 at 09 27 07

@nkaretnikov nkaretnikov marked this pull request as ready for review August 23, 2023 07:41
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nkaretnikov!

@nkaretnikov
Copy link
Contributor Author

@costrouc I have no write access to the repo. Can you merge it? Or are we waiting for other approvals?

@costrouc costrouc merged commit 1b88b50 into conda-incubator:main Aug 23, 2023
7 checks passed
@costrouc
Copy link
Member

Was waiting for the ci to pass just in case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

CondaStore.conda_allowed_channels should by default allow all channels
3 participants