Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conda-docker a dependency in Linux only in pyproject.toml #583

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

asmeurer
Copy link
Contributor

Fixes #578 .

Note, we will also need to make sure to fix this in the conda-forge feedstock.

Description

This pull request:

  • a
  • b
  • c

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit c099ca8
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6508a9339733b0000860111e

@asmeurer
Copy link
Contributor Author

Note that conda-docker is actually perfectly pip installable on all platforms, it just won't work when the platform isn't Linux (but it can be imported).

@asmeurer
Copy link
Contributor Author

The reason is that the Linux-only dependency, fakechroot, is not a Python package. It's an executable that gets called at runtime. It is, however, a dependency in the conda package which cannot be installed on Linux.

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this LGTM 🚀 merging now!

@trallard trallard merged commit e156129 into conda-incubator:main Sep 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Can't install conda-store-server on M1 MacOS
2 participants