Set channel priority to strict, print config info #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kaleidoscopic-dango-0cf31d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
nkaretnikov
commented
Dec 11, 2023
nkaretnikov
commented
Dec 11, 2023
nkaretnikov
commented
Dec 11, 2023
nkaretnikov
commented
Dec 11, 2023
This comment was marked as outdated.
This comment was marked as outdated.
trallard
added
area: configuration
area: user experience 👩🏻💻
This was referenced Dec 12, 2023
trallard
requested changes
Dec 14, 2023
There was a problem hiding this comment.
Thanks @nkaretnikov - I left a few comments and questions.
I generally do not like to use print for what should be logged or streamed, so unless there is a strong reason to use print this should be changed
conda-store-server/conda_store_server/action/generate_lockfile.py
Outdated
Show resolved
Hide resolved
nkaretnikov
force-pushed
the
channel-priority-359
branch
from
7f2dd1b
to
973a2a4
Compare
trallard
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the channel priority to strict to avoid issues during solves when multiple channels that were not specified are being used. This is done by passing the command line option
--strict-channel-priorityvia the environment variableCONDA_FLAGS, which is used by conda-lock, which is a library conda-store uses to solve dependencies.CONDA_FLAGSis used because it's a method of passing options that's local to conda-lock as opposed to editing global conda configuration files. Editing user configuration files may lead to unexpected issues in contexts where conda-store is used in standalone mode. Those configuration files affect how conda works outside of conda-store, which might be important to end users.From the documentation at https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-channels.html:
Additionally, this PR adds code that prints useful system information related to conda configuration before the package solving process. This is useful for debugging. The commands used are:
conda/mamba info, depending on the value ofconda_store.conda_commandconda config --showconda config --show-sources.Note that the latter two commands are not supported by mamba, which is why conda is used.
Fixes #359, fixes #659.