add changelog entries for #94 #95 #100 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bollwyvl
reviewed
Nov 17, 2020
CHANGELOG.md
Outdated
| @@ -5,6 +5,9 @@ | |||
| ## Fixes | |||
|
|
|||
| - [#97][] fixes `installer-url` on Windows | |||
| - [#94][], [#95][] catch ignored errors when an environment file contains | |||
| invalid section names | |||
| - [#100][] fix `mamba` not being available on Windows if using a `bash` shell | |||
There was a problem hiding this comment.
Ooops, i missed my link target, as do these... just needs the refs like the one below... they are all pulls except #97, which is under `issues. I guess as to convention:
- it's talking about "(the release) fixes" or "(the release) catches"... not a big deal, but makes it more consistent to read
- for fixes, if there is an original issue, that number is probably more interesting, as (as we've seen) it can take a couple PRs to finally fix something
There was a problem hiding this comment.
Heh, ok. I thought somehow that link targets were added at the end. Would we be interested in having a PR template with all these things?
|
Thanks for working on this @jaimergp :) ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #98 (comment)