Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bash commands to include error flag #256

Merged
merged 2 commits into from
Nov 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/workflows/caching-envs-example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ jobs:
- name: Setup Mambaforge
uses: conda-incubator/setup-miniconda@v2
with:
miniforge-variant: Mambaforge
miniforge-version: latest
activate-environment: anaconda-client-env
use-mamba: true
miniforge-variant: Mambaforge
miniforge-version: latest
activate-environment: anaconda-client-env
use-mamba: true

- name: Get Date
id: get-date
run: echo "::set-output name=today::$(/bin/date -u '+%Y%m%d')"
Expand All @@ -41,12 +41,18 @@ jobs:
uses: actions/cache@v2
with:
path: ${{ env.CONDA }}/envs
key: conda-${{ runner.os }}--${{ runner.arch }}--${{ steps.get-date.outputs.today }}-${{ hashFiles('etc/example-environment-caching.yml') }}-${{ env.CACHE_NUMBER }}
key:
conda-${{ runner.os }}--${{ runner.arch }}--${{
steps.get-date.outputs.today }}-${{
hashFiles('etc/example-environment-caching.yml') }}-${{
env.CACHE_NUMBER }}
env:
# Increase this value to reset cache if etc/example-environment.yml has not changed
CACHE_NUMBER: 0
id: cache

- name: Update environment
run: mamba env update -n anaconda-client-env -f etc/example-environment-caching.yml
run:
mamba env update -n anaconda-client-env -f
etc/example-environment-caching.yml
if: steps.cache.outputs.cache-hit != 'true'
4 changes: 2 additions & 2 deletions .github/workflows/example-1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ jobs:
auto-update-conda: true
python-version: ${{ matrix.python-version }}
- name: Conda info
shell: bash -l {0}
shell: bash -el {0}
run: conda info
- name: Conda list
shell: pwsh
run: conda list
- name: Environment
shell: bash -l {0}
shell: bash -el {0}
run: printenv | sort
4 changes: 2 additions & 2 deletions .github/workflows/example-10.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ${{ matrix.os }}-latest
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
strategy:
fail-fast: false
matrix:
Expand All @@ -48,7 +48,7 @@ jobs:
runs-on: ${{ matrix.os }}-latest
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
strategy:
fail-fast: false
matrix:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/example-11.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ jobs:
${{ steps.setup-miniconda.outcome == 'success' }}
fi
- name: Conda info
shell: bash -l {0}
shell: bash -el {0}
run: conda info
- name: Conda list
shell: pwsh
run: conda list
- name: Environment
shell: bash -l {0}
shell: bash -el {0}
run: printenv | sort
6 changes: 3 additions & 3 deletions .github/workflows/example-2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
miniconda-version: "latest"
activate-environment: foo
- name: Bash
shell: bash -l {0}
shell: bash -el {0}
run: |
conda info
conda list
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
conda list
printenv | sort
- name: Bash
shell: bash -l {0}
shell: bash -el {0}
run: |
conda info
conda list
Expand All @@ -77,7 +77,7 @@ jobs:
activate-environment: foo
use-only-tar-bz2: true
- name: Bash
shell: bash -l {0}
shell: bash -el {0}
run: |
conda info
conda list
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/example-3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: "ubuntu-latest"
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
steps:
- uses: actions/checkout@v2
- uses: ./
Expand All @@ -42,7 +42,7 @@ jobs:
runs-on: "ubuntu-latest"
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
steps:
- uses: actions/checkout@v2
- uses: ./
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/example-4.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: "ubuntu-latest"
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
steps:
- uses: actions/checkout@v2
- uses: ./
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/example-5.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
MINIFORGE_URL: https://github.com/conda-forge/miniforge/releases/download/4.9.0-3/Miniforge-pypy3-4.9.0-3-Linux-x86_64.sh
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
steps:
- uses: actions/checkout@v2
- run: |
Expand All @@ -47,7 +47,7 @@ jobs:
runs-on: "macos-latest"
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
steps:
- uses: actions/checkout@v2
- uses: ./
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
show-channel-urls: true
use-only-tar-bz2: true
activate-environment: ""
- shell: bash -l {0}
- shell: bash -el {0}
run: |
conda info
conda list
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/example-6.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
activate-environment: c:\ace
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
steps:
- uses: actions/checkout@v2
- uses: ./
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/example-7.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ${{ matrix.os }}
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: "ubuntu-latest"
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
steps:
- uses: actions/checkout@v2
- run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/regression-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ${{ matrix.os }}-latest
defaults:
run:
shell: bash -l {0}
shell: bash -el {0}
strategy:
fail-fast: false
matrix:
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ convention, are also checked in.

- Create Conda env with `nodejs`:

We use NodeJS version 14 for now.
We use NodeJS version 16 for now.

```bash
conda create -n github-action nodejs=14 -c conda-forge
conda create -n github-action nodejs=16 -c conda-forge
```

- Install NodeJS dependencies:
Expand Down
Loading