Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip/update dependencies #314

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Strip/update dependencies #314

merged 1 commit into from
Nov 23, 2023

Conversation

dbast
Copy link
Member

@dbast dbast commented Nov 23, 2023

Unused/missing dependencies identified via:

npm install -g depcheck && depcheck

Updated remaining dependencies via:

npm install -g npm-check-updates && npm-check-updates -u

Applied changes via:

rm -rf node_modules
npm install
npm run format
npm run build

The prettier config was loaded in eslint, but no rule applied. depcheck thus reported eslint-plugin-prettier as unused. By not loading the prettier eslint config also eslint-config-prettier could be removed.

Less dependencies = lees breakages / vulnerabilities / updates.

@dbast dbast requested a review from a team as a code owner November 23, 2023 15:33
@dbast dbast marked this pull request as draft November 23, 2023 15:34
Unused/missing dependencies identified via:

```
npm install -g depcheck && depcheck
```

Updated remaining dependencies via:

```
npm install -g npm-check-updates && npm-check-updates -u
```

Applied changes via:
```
rm -rf node_modules
npm install
npm run format
npm run build
```

The prettier config was loaded in eslint, but no rule applied. depcheck thus reported eslint-plugin-prettier as unused. By not loading the prettier eslint config also eslint-config-prettier could be removed.

Less dependencies = lees breakages / vulnerabilities / updates.
@dbast dbast marked this pull request as ready for review November 23, 2023 15:45
@goanpeca goanpeca merged commit 93c8c0f into conda-incubator:main Nov 23, 2023
49 checks passed
@dbast dbast deleted the depclean branch November 25, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants