Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/regression in meta.yaml 'build/no_link' handling: overwriting no_link list with boolean #1607

Closed
mwiebe opened this issue Dec 30, 2016 · 1 comment · Fixed by #1611
Closed
Labels
locked [bot] locked due to inactivity
Milestone

Comments

@mwiebe
Copy link
Contributor

mwiebe commented Dec 30, 2016

conda-build version 2.0.12

The bug is that at https://github.com/conda/conda-build/blob/master/conda_build/build.py#L563 the list gets created:

no_link = m.get_value('build/no_link')

but then the same variable is overwritten with a bool at https://github.com/conda/conda-build/blob/master/conda_build/build.py#L574

no_link = is_no_link(no_link, fi)

so next time around the loop, it gives the traceback:

Traceback (most recent call last):
  File "C:\Anaconda3\Scripts\conda-build-script.py", line 5, in <module>
    sys.exit(conda_build.cli.main_build.main())
  File "C:\Anaconda3\lib\site-packages\conda_build\cli\main_build.py", line 255, in main
    execute(sys.argv[1:])
  File "C:\Anaconda3\lib\site-packages\conda_build\cli\main_build.py", line 247, in execute
    already_built=None, config=config, noverify=args.no_verify)
  File "C:\Anaconda3\lib\site-packages\conda_build\api.py", line 75, in build
    need_source_download=need_source_download, config=config)
  File "C:\Anaconda3\lib\site-packages\conda_build\build.py", line 1231, in build_tree
    config=recipe_config)
  File "C:\Anaconda3\lib\site-packages\conda_build\build.py", line 924, in build
    create_info_files(m, pkg_files, config=config, prefix=config.build_prefix)
  File "C:\Anaconda3\lib\site-packages\conda_build\build.py", line 469, in create_info_files
    create_info_files_json(m, config.info_dir, prefix, files, files_with_prefix)
  File "C:\Anaconda3\lib\site-packages\conda_build\build.py", line 570, in create_info_files_json
    files_json_files = build_info_files_json(m, prefix, files, files_with_prefix)
  File "C:\Anaconda3\lib\site-packages\conda_build\build.py", line 550, in build_info_files_json
    no_link = is_no_link(no_link, fi)
  File "C:\Anaconda3\lib\site-packages\conda_build\build.py", line 517, in is_no_link
    if no_link is not None and short_path in no_link:
TypeError: argument of type 'bool' is not iterable
@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically locked because it has not had recent activity after being closed.

Please open a new issue if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants