Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set PIP_* env vars for outputs/script #5368

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Set PIP_* env vars for outputs/script #5368

merged 3 commits into from
Jun 21, 2024

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Jun 11, 2024 •
edited
Loading

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

Fixes #3993

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 11, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5368 will not alter performance

Comparing isuruf:pip_outputs (0a011ca) with main (3515dbe)

Summary

✅ 3 untouched benchmarks

@isuruf isuruf marked this pull request as ready for review June 11, 2024 21:16
@isuruf isuruf requested a review from a team as a code owner June 11, 2024 21:16
@isuruf isuruf added this to the 24.7.x milestone Jun 14, 2024
@isuruf isuruf merged commit ee7d0ce into conda:main Jun 21, 2024
28 checks passed
@isuruf
Copy link
Contributor Author

isuruf commented Jun 21, 2024

Thanks for the review

@isuruf isuruf deleted the pip_outputs branch June 21, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Status: 🏁 Done
Milestone
24.7.x
Development

Successfully merging this pull request may close these issues.

PIP_NO_DEPENDENCIES & co not set for outputs/*/script
3 participants
@isuruf @beckermr @conda-bot