Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit config #35

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Add pre-commit config #35

merged 2 commits into from
Aug 5, 2022

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jul 26, 2022

Description

This is mostly just a copy from https://github.com/conda/conda/blob/main/.pre-commit-config.yaml.

Autofixing is explicitly disabled:

# disable autofixing PRs, commenting "pre-commit.ci autofix" on a pull request triggers a autofix
ci:
autofix_prs: false

This adds pre-commit checks for:

  1. mixed-line-ending
  2. end-of-file-fixer
  3. trailing-whitespace
  4. check-toml
  5. check-yaml
  6. check-json
  7. check-merge-conflict
  8. fix-encoding-pragma
  9. darker
  10. blacken-docs
  11. flake8

    Note
    Results are ignored (see --exit-zero)

  12. pylint

    Note
    Results are ignored (see --exit-zero)

  13. bandit

    Note
    Results are ignored (see --exit-zero)

  14. insert-license

Once this is ready to merge we will need to enable the pre-commit CI bot (see checklist below).

Supersedes #34

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 26, 2022
@kenodegard kenodegard requested a review from awwad July 26, 2022 19:21
@kenodegard kenodegard added the in-progress issue is actively being worked on label Jul 26, 2022
@kenodegard
Copy link
Contributor Author

@awwad let's merge this so pre-commit can be installed locally and run as part of git commit hooks, we will postpone enabling pre-commit CI

This was referenced Aug 5, 2022
@kenodegard kenodegard merged commit 50d53c5 into conda:main Aug 5, 2022
@kenodegard kenodegard deleted the pre-commit branch August 5, 2022 15:07
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA in-progress issue is actively being worked on locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants