Report all missing packages from channel #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
conda.exceptions
has many classes to play with if packages are not found:conda
raisesPackagesNotFoundError
. For the message to mention the offending channels, this exception class needs achannels
kwarg. Otherwise, it'll default to "missing from target environment" messaging. We were missing this kwarg, so the messaging was wrong.PackageNotInstalledError
, which takes aprefix
kwarg too, and mentions it in the messaging. However, this only accepts a single package name 馃しThis PR simply fixes our missing kwarg so the messaging is correct.
Before this PR:
After this PR:
This closes #96.
(Note this output still suffers from the double attempt issue reported in #100)
Checklist - did you ...
news
directory (using the template) for the next release's release notes?