Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require py38+, do not require importlib-metadata #174

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Require py38+, do not require importlib-metadata #174

merged 3 commits into from
Mar 31, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Mar 31, 2023 •
edited

Description

The conda ecosystem does not support Python 3.7 anymore, so no need for us either. This also allows us to remove importlib-metadata from the dependency list.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 31, 2023
@jaimergp jaimergp added the build::review trigger a build for this PR label Mar 31, 2023
@conda-bot conda-bot removed the build::review trigger a build for this PR label Mar 31, 2023
@conda-bot
Copy link
Contributor

conda-bot commented Mar 31, 2023 •
edited

Review build status

The workflow for building and uploading a canary release for conda-libmamba-solver with the label conda-libmamba-solver-pr-174 in channel conda-canary was started by @jaimergp!

Once it's done, use this command to try it out in a new conda environment:

conda install -c conda-canary/label/conda-libmamba-solver-pr-174 conda-libmamba-solver

@jaimergp jaimergp marked this pull request as ready for review March 31, 2023 08:37
@jaimergp jaimergp mentioned this pull request Mar 31, 2023
Closed
20 tasks
@jaimergp jaimergp added this to the March 2023 release milestone Mar 31, 2023
@jezdez jezdez changed the title require py38+, do not require importlib-metadata Require py38+, do not require importlib-metadata Mar 31, 2023
@jezdez jezdez merged commit cfa9084 into main Mar 31, 2023
73 of 74 checks passed
@jezdez jezdez deleted the no-py37 branch March 31, 2023 12:09
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
🔎 Review
Archived in project
Milestone
March 2023 release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaimergp @conda-bot @jezdez