Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subcommand plugin for repoquery #258

Merged
merged 11 commits into from
Aug 29, 2023
Merged

add subcommand plugin for repoquery #258

merged 11 commits into from
Aug 29, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Aug 10, 2023

Description

We had the backend bits but not the CLI :)

This could be merged with conda search too.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 10, 2023
@jezdez
Copy link
Member

jezdez commented Aug 17, 2023

That's a nice surprise! <3

@costrouc
Copy link
Contributor

Looks awesome! And makes perfect sense that this plugin would include repoquery since it's in mamba/micromamba.

@jaimergp jaimergp marked this pull request as ready for review August 22, 2023 07:58
@jaimergp jaimergp requested a review from jezdez August 24, 2023 08:34
@jaimergp
Copy link
Contributor Author

Failures in upstream are unrelated, and caused by conda/conda#9614

Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits around help texts and return values.

conda_libmamba_solver/plugin.py Outdated Show resolved Hide resolved
"--installed",
action="store_true",
default=True,
help=argparse.SUPPRESS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to suppress this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copied over from the original mamba module 🤷

conda_libmamba_solver/repoquery.py Outdated Show resolved Hide resolved
conda_libmamba_solver/repoquery.py Outdated Show resolved Hide resolved
conda_libmamba_solver/repoquery.py Outdated Show resolved Hide resolved
conda_libmamba_solver/repoquery.py Outdated Show resolved Hide resolved
conda_libmamba_solver/repoquery.py Outdated Show resolved Hide resolved
conda_libmamba_solver/repoquery.py Outdated Show resolved Hide resolved
conda_libmamba_solver/repoquery.py Outdated Show resolved Hide resolved
conda_libmamba_solver/repoquery.py Outdated Show resolved Hide resolved
Co-authored-by: Jannis Leidel <jannis@leidel.info>
@jaimergp jaimergp merged commit 1443a46 into main Aug 29, 2023
46 of 75 checks passed
@jaimergp jaimergp deleted the repoquery-cli branch August 29, 2023 07:57
@jaimergp jaimergp added this to the September 2023 release milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants