Require libmambapy 1.5.3 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
Note that libmamba 1.5.3 is not on defaults yet, but the CI seems to be getting it from 1.5.3 from conda-forge anyway (even on the defaults CI entries), hence why everything's passing. |
3 tasks
dholth
reviewed
Nov 1, 2023
| api_ctx.set_verbosity(context.verbosity) | ||
| if output_params.json: | ||
| if api_ctx.output_params.json: |
There was a problem hiding this comment.
We are cancelling some other json if json is True?
There was a problem hiding this comment.
We don't want libmamba to print JSON on its own. It's something only conda should do.
kenodegard
approved these changes
Nov 1, 2023
jezdez
approved these changes
Nov 1, 2023
|
Merging with failures because they are connection errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This release includes a few fixes that we have needed in conda-libmamba-solver for a while, including:
defaults::pkgandpkgs/main::pkgspecs (Some backports mamba-org/mamba#2936)Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?