Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop md5 and sha256 fields from MatchSpec (they are ignored anyway) #429

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Drop md5 and sha256 fields from MatchSpec (they are ignored anyway) #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a344d46
drop md5 and sha256 from MatchSpec (they are ignored anyway)
jaimergp Jan 26, 2024
f5a9366
amend news
jaimergp Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda_libmamba_solver/solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,7 @@ def _check_spec_compat(self, match_spec: Union[MatchSpec, None]) -> Union[MatchS
if match_spec is None:
return None
supported = "name", "version", "build", "channel", "subdir"
droppable = ("url",)
droppable = ("url", "md5", "sha256")
unsupported_but_set = []
to_drop = set()
to_keep = {}
Expand Down
2 changes: 1 addition & 1 deletion news/421-matchspec-validation
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### Bug fixes

* Do not raise error if an unsupported `MatchSpec` field can be safely dropped instead. (#418 via #421)
* Do not raise an error if an unsupported `MatchSpec` field can be safely dropped instead. Currently ignoring `url`, `md5` and `sha256`. (#418 via #421, #427 via #429).

### Deprecations

Expand Down