-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load all channels with conda internals #65
Conversation
Remaining errors have to do with |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
We've merged a new conda that changes the way repodata.json is dowloaded, and we will change it again in the next release. Is this code compatible with the new conda? conda/conda#12050 also helps a lot avoiding wasted parsing. |
Nope, conda/conda#12003 changed the internal API so as a matter of facts everything will fail here as it is now. I am inclined to wait til things get calmer around the repodata fetching logic before working on this PR further. What do you think @dholth? |
I concur, let's move this to a later milestone. |
This one is failing sporadically. It can be reproduced locally by rerunning it several times; it will pass 4 out of 5 times or so. I wonder if this has to do with some change in 1.4.1 (this is the first time I see it fail, if memory serves). |
…ibmamba-solver into remove-libmamba-networking
I added some stdout in the spinner (so it hides when needed; e.g. --json or --quiet), and it looks like this: During fetch:
Once done:
|
Nice! |
Description
Closes #59
We are replacing the libmamba networking stack with conda internals:
conda.SubdirData.repo_fetch
interface that doesn't process the JSON (only downloads).libmambapy.Repo
, without theSubdirData
indirection. This interface allow us to use a JSON file directly (without having to be optimistic about the "find the JSON file" logic inSubdirData
).There's some legacy issues we should remove in the future:
SubdirData
subclass can introduce some issues with incomplete cache entries we have to invalidate (some tests break otherwise), because metaclass-based caches are that fun.SubdirData._cache_
a bit too much and some of those changes are not reflected on disk. Some changes upstream will alleviate this.conda.testing.helpers._patch_for_local_exports
to not patch_mtime
toinf
. Return early if the solver is classic because that function is not needed there.