Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add os_name environment marker for platform-dependent pypi dependencies #295

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

scottyhq
Copy link
Contributor

fixes #293

Adds the "os_name" environment marker (https://peps.python.org/pep-0508/#environment-markers) used by some packages to mark platform-specific dependencies, for example jupyter_server:

requires-python = ">=3.8"
dependencies = [
    "anyio>=3.1.0,<4",
    "pywinpty;os_name=='nt'",

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit aa8bbb8
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63991d5682f1680009ebb101
😎 Deploy Preview https://deploy-preview-295--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@scottyhq
Copy link
Contributor Author

Hmmm, test_run_lock_blas_mkl[micromamba] is failing just on Windows and i'm not sure how to remedy...

E               KeyError: 'md5'
D:\a\conda-lock\conda-lock\conda_lock\conda_solver.py:282: KeyError

full traceback in the CI logs here

@mariusvniekerk
Copy link
Collaborator

mariusvniekerk commented Dec 14, 2022

Probably just some weird edge case to ignore, I've seen micromamba on windows have some rather exotic behavior

@scottyhq
Copy link
Contributor Author

scottyhq commented Jan 4, 2023

OK @mariusvniekerk let me know if there are any changes I can make to merge this in

@maresb
Copy link
Contributor

maresb commented Feb 13, 2023

Sorry for the review delay. This looks good to me. Would it be possible to add #293 as a test case?

Note: the os_name marker is set to os.name which is either posix or nt as per the os builtin module.

@netlify
Copy link

netlify bot commented Feb 25, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit d0138b6
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63fa2f02c4cbd200086a7af3
😎 Deploy Preview https://deploy-preview-295--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip solver does not consider dependencies conditional on platform
3 participants