Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bottom pin for gitpython #318

Merged
merged 3 commits into from
Feb 25, 2023
Merged

add bottom pin for gitpython #318

merged 3 commits into from
Feb 25, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jan 17, 2023

References

Changes

  • restore gitpython as a hard dep
  • remove the lazy import
    • kind of inclined to keep it lazy

Alternatives

  • keep this as an optional dependency, as it's a relatively niche metadata option that incurs three additional dependencies

@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit ebaf1de
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63c6dd88ef686d00085c3b1f
😎 Deploy Preview https://deploy-preview-318--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mariusvniekerk
Copy link
Collaborator

Do we need to wait for the CVE to be reported as fixed?

@bollwyvl
Copy link
Contributor Author

Do we need to wait for the CVE to be reported as fixed?

Yeah, I guess to close the loop, it probably makes sense to wait for updated findings.

@maresb
Copy link
Contributor

maresb commented Feb 16, 2023

This was modified on Feb 6th to have an up to (excluding) pin:
image

I'm guessing this makes it ready to merge?

BTW, since we have a sensible error message, I'm not opposed to the alternative of keeping gitpython optional.

@maresb maresb requested a review from a team as a code owner February 16, 2023 22:33
@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit f51f6b3
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63eeaf587d025700084c6c75
😎 Deploy Preview https://deploy-preview-318--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mariusvniekerk mariusvniekerk merged commit 6800ba2 into conda:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants