Apply auth also for private pypi packages #323
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@maresb whom do I need to bribe to get this reviewed? :) |
|
Hi @croth1! I don't have much time these days, but at least this one is nice and short! You could start by bribing me with a test case so that we can prevent regressions. 🙂 Thanks! |
|
@maresb, I integrated the new logic into existing test cases - strictly speaking the auth stripping logic does not seem to be needed for pypi, as the current poetry code does that automatically. |
There was a problem hiding this comment.
Thanks so much @croth1 for your persistence and patience on this!!!
(I wasn't so familiar with this code, so even though this is straightforward, it's been tricky for me to find the time to look properly at this. Not to mention that the current directory structure for these test files confuses me; perhaps we should eventually clean that up.)
This looks really excellent. Could you please add test cases for test__add_auth_to_line, test__strip_auth_from_line, test__extract_domain? Luckily these tests are self-contained, so I think this will be quick and easy.
Once that's done, it looks good from my side. Anything to add, @mariusvniekerk?
Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks so much @croth1!!! |
previous logic converted all lock files to explicit type and ignored all lines starting with
#or@. This however does not allow adding auth to packages from private pypi indices, as they are represented as# pip package @ index_urland thus were skipped in the auth re-adding logic.