Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs after graduation #324

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Update URLs after graduation #324

merged 3 commits into from
Feb 6, 2023

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Jan 31, 2023

Description

Update some URLs following #319.

@@ -292,11 +292,11 @@ def install(args, parser, command='install'):
# Other solvers might implement their own internal retry logic without
# depending --freeze-install implicitly like conda classic does. Example
# retry loop in conda-libmamba-solver:
# https://github.com/conda-incubator/conda-libmamba-solver/blob/da5b1ba/conda_libmamba_solver/solver.py#L254-L299
# https://github.com/conda/conda-libmamba-solver/blob/da5b1ba/conda_libmamba_solver/solver.py#L254-L299
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jezdez I believe you use some global search and replace here, right? These two URLs won't be the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, and fixed in cb682df

@maresb maresb mentioned this pull request Feb 4, 2023
2 tasks
@maresb
Copy link
Contributor

maresb commented Feb 4, 2023

Probably closes #326

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge.

@maresb maresb merged commit 2161a61 into main Feb 6, 2023
@dbast dbast deleted the graduation-fixes branch February 6, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants