Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable codecov coverage reporting #333

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Enable codecov coverage reporting #333

merged 1 commit into from
Feb 6, 2023

Conversation

dbast
Copy link
Member

@dbast dbast commented Feb 6, 2023

Allows to see what is tested (or also what is potentially dead code).

Also:

  • Move all pytest settings to pyproject.toml
  • Fix omit property (=path glob)
  • Use settings from pyproject.toml during test runs
  • Disable codecov status reporting / comments to PRs (active after merge to main branch).
  • Make coverage link available via badge in the README

Description

Allows to see what is tested or what is potentially dead code.

Also:
* Move all pytest settings to pyproject.toml
* Fix `omit` property (=PATH glob)
* Use settings from pyproject.toml during test runs
* Disable codecov status reporting / comments to PRs (active after merge
  to main branch).
* Make coverage link available via badge in the README
@dbast dbast requested a review from a team February 6, 2023 14:17
@dbast
Copy link
Member Author

dbast commented Feb 6, 2023

@@ -53,7 +53,7 @@ ignore = [

[tool.coverage.run]
omit = [
"conda_lock/vendor/*",
"*/conda_lock/_vendor/*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering, why have */ here? Is it not relative to project root? Or is the idea that it should work even if we move it to src/conda_lock?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried without the first */ ... didn't work... seems to be not the project root, but the installed location in the conda env ... others are setting e.g. */site-packages/.../*.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, good to know, thanks!

@maresb maresb merged commit 33f1f12 into conda:main Feb 6, 2023
@dbast dbast deleted the coverage branch February 6, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants