Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all References of pip_support Flag #340

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

srilman
Copy link
Contributor

@srilman srilman commented Feb 9, 2023

Description

Closes #339 by removing any references of the pip_support extra from the docs and README. It also removes the vacuous use of the PIP_SUPPORT flag and anywhere that flag is passed into, especially in the conda_lock.src_parser.environment_yaml.py module.

@srilman srilman requested a review from a team as a code owner February 9, 2023 23:23
@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 0b54d62
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63e618031a6f1a000810437e
😎 Deploy Preview https://deploy-preview-340--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@srilman
Copy link
Contributor Author

srilman commented Feb 9, 2023

I'm seeing test cases that use Docker Quetz error out at the setup stage:

ERROR at setup of test_private_lock[conda-$QUETZ_API_KEY]
...

I don't see anything in conftest.py that indicates that this PR was the cause of the issue, so I will rerun CI in ~1 hour or so.

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! Looks excellent.

I just restarted the failing tests.

@srilman
Copy link
Contributor Author

srilman commented Feb 10, 2023

I just restarted the failing tests.

Thanks @maresb!

@srilman
Copy link
Contributor Author

srilman commented Feb 10, 2023

Hmm, I'm still seeing the Quetz tests erroring out in the pytest fixture quetz_server

@maresb
Copy link
Contributor

maresb commented Feb 10, 2023

Regarding Quetz failures see #338. I think we just keep retrying for now. 🙁

@maresb maresb merged commit d24d790 into conda:main Feb 10, 2023
@maresb
Copy link
Contributor

maresb commented Feb 10, 2023

Thanks @srilman!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PIP_SUPPORT Flag from Codebase
2 participants