Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke codecov only in CI #352

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Invoke codecov only in CI #352

merged 1 commit into from
Feb 16, 2023

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Feb 15, 2023

Closes #351

@netlify
Copy link

netlify bot commented Feb 15, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit f431373
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63eca684a8783c000964abae
😎 Deploy Preview https://deploy-preview-352--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maresb maresb requested a review from dbast February 15, 2023 09:33
@maresb
Copy link
Contributor Author

maresb commented Feb 15, 2023

Hi @dbast, could you please take a look at issue #351 when you get the chance? For some reason, codecov seems to break interactive debugging in VS Code and more. Have you run into this before? Does this PR look like a sensible fix, or do you have another suggestion? Thanks!!!

@dbast
Copy link
Member

dbast commented Feb 15, 2023

Makes sense to be... a pity, but seems to be the best option to do it like that... there is also microsoft/vscode-python#693 (comment) but that requires configuration on dev side.

@maresb maresb marked this pull request as ready for review February 15, 2023 10:36
@maresb maresb requested a review from a team as a code owner February 15, 2023 10:36
@maresb
Copy link
Contributor Author

maresb commented Feb 15, 2023

Ya, I thought about that comment, but it seems to me like it's VS Code specific solution, while the issue affects other IDEs as well.

Thanks a lot for the quick approval! I'll merge soon, but I'm happy to revisit this if another solution emerges.

@maresb maresb merged commit 269de01 into conda:main Feb 16, 2023
@maresb maresb deleted the move-codecov-to-ci branch February 16, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov seems to break interactive debugging
2 participants