Warn when pyproject.toml dependencies are dynamic #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
maresb
force-pushed
the
warn-on-dynamic-dependencies
branch
from
bd4e29b
to
3c07f7b
Compare
maresb
added a commit
to maresb/conda-lock
that referenced
this pull request
Feb 19, 2023
This makes our dependencies declarative rather than dynamic. See conda#356.
mariusvniekerk
approved these changes
Feb 24, 2023
maresb
added a commit
to maresb/conda-lock
that referenced
this pull request
Feb 25, 2023
This makes our dependencies declarative rather than dynamic. See conda#356.
maresb
added a commit
to maresb/conda-lock
that referenced
this pull request
Feb 25, 2023
This makes our dependencies declarative rather than dynamic. See conda#356.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If dependencies are specified dynamically in
pyproject.toml(e.g. like currently in conda-lock), then they can't be parsed without first building the project. This PR doesn't implement a fix, but rather it emits a warning that dependencies will be ignored for now. To aid future work, an explanatory comment includes details and references.