Refactor lookup._LookupLoader #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
maresb
force-pushed
the
refactor-lookup
branch
from
c149b7f
to
e695819
Compare
|
Here is an instance in the CI of the failure I was seeing: |
Locally I see test failures in test_choose_wheel due to the assertion in conda_lookup() failing. It seems to result from flaky caching logic. Using python>=3.8, we can get rid of most of the boilerplate. In a subsequent PR we could also remove the module-level boilerplate.
|
@mariusvniekerk this occurs an order-of-magnitude less than the md5 keyerror, but this still occasionally snags up the CI. |
2 tasks
mariusvniekerk
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally I see test failures in
test_choose_wheeldue to the assertion inconda_lookup()failing. It seems to result from flaky caching logic. Usingpython>=3.8's functools, we can get rid of most of the boilerplate. In a subsequent PR we could also remove the module-level boilerplate.In short,
_LookupLoaderwas implementing a bunch of caching functionality by hand. This simply uses modern Python andfunctoolsto eliminate all that boilerplate.