-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows compatibility #48
Conversation
Before I review (hopefully tomorrow), could you quick fix the merge conflicts that have popped up? This will make it easier to review, and get testing setup on the main branch. Thanks for all your work here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcrist I've resolved the latest merge conflicts with master.
Passing build on Windows is here: https://ci.appveyor.com/project/dsludwig/conda-pack/build/1.0.13
@dsludwig, the Travis tests fail. Do you know how to fix that? |
Thanks for the ping @certik, I found the problem in the tests. It's passing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes on linux seem fine to me, and the linux tests pass on Travis, so I would say it's ok. If something broke, we should improve the linux tests.
Regarding the changes on Windows, they look ok as the first iteration, and so I suggest to merge it, so that the appveyor tests get enabled, and so we can then send subsequent PRs and they will get tested on Windows.
@jcrist would you please mind reviewing it and merging?
@jcrist ping. |
AppVeyor is passing here, but holy cow is it slow. |
OK, I spoke to soon; @dsludwig, it looks like it's not passing with Python 3 |
Ah ok then sorry for the noise. Do what you will with them (within reason!) |
463ef39
to
f68ace0
Compare
Last test failure was a flake issue. Functional tests passing. |
Now the only test that doesn't run on Windows is |
Thanks everybody! |
@jcrist Any idea when this will be released? I am waiting eagerly for the next release on conda-forge so that I can utilize this without installing from source. |
I expect to issue a release sometime in the next week. |
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Replaces #46
Includes an appveyor configuration for Windows CI: https://ci.appveyor.com/project/dsludwig/conda-pack/
There's an outstanding issue when the archives are extracted on a case-sensitive file-system, but I didn't want to add that complexity for what is likely not a common case. I've included an extensive comment that explains the issue in more detail.