Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log sha256 of created packages #209

Closed
wants to merge 1 commit into from
Closed

Log sha256 of created packages #209

wants to merge 1 commit into from

Conversation

dbast
Copy link
Member

@dbast dbast commented May 26, 2023

Description

This logs the sha256 of every created package, no matter if called from conda-build or done via transmute.

It allows to co-relate build/transmute logs with cryptographic safety, meaning any package in the wild can via its sha256 traced back to its build log with very high probability as sha256 collisions are very unlikely/hard to generate.

Not yet 100% sure if that is the right place to do... it could be also done within conda-build right after the create call.. though doing it in cph also covers the transmute case.

@jaimergp maybe also interesting for you :)

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 26, 2023
@dbast dbast force-pushed the sha256 branch 2 times, most recently from 5877ca2 to 03cf770 Compare May 26, 2023 15:47
@dbast dbast marked this pull request as ready for review May 26, 2023 16:02
Copy link
Contributor

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have some concerns about memory usage that are easy to address with a chunking approach.

src/conda_package_handling/conda_fmt.py Outdated Show resolved Hide resolved
src/conda_package_handling/conda_fmt.py Outdated Show resolved Hide resolved
src/conda_package_handling/tarball.py Outdated Show resolved Hide resolved
tests/test_interface.py Outdated Show resolved Hide resolved
@dbast
Copy link
Member Author

dbast commented Jul 27, 2023

closing this ... I think a better place would be to print the sha256 sums which conda-index anyways calculates during conda-build runs.

@dbast dbast closed this Jul 27, 2023
@dbast dbast deleted the sha256 branch July 27, 2023 06:05
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants