add cph list subcommand
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
kenodegard
requested changes
Apr 2, 2024
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
kenodegard
approved these changes
Apr 2, 2024
5 tasks
dholth
reviewed
Apr 2, 2024
| for component in _stream_components(filename, components): | ||
| for tar, _ in component: | ||
| with redirect_stdout(memfile): | ||
| tar.list(verbose=verbose) |
dholth
reviewed
Apr 2, 2024
| key=lambda line: line.split(None, 5)[-1], | ||
| ) | ||
| else: | ||
| lines = sorted(memfile.readlines()) |
There was a problem hiding this comment.
I was trying to achieve output order consistency. In .conda artifacts, the info/ block will be always put in the end. I've also seen some pkg components containing stuff under info/.
|
Great work, thanks |
|
Any further comments that need to be addressed? Thanks @dholth |
dholth
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reuses
tarfile.Tarfile.list()across .tar.bz2 and .conda artifacts. The unified interface with the tar generator makes it super easy!This should help with inspecting artifact contents without having to pay for extraction. I picture this in post-conda-build reports in CI.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?