Skip to content

Commit

Permalink
Replace flake package spec for test (#13034)
Browse files Browse the repository at this point in the history
Use a package spec (`conda-package-handling`) for testing that is less likely to trigger false-positives by security scanning tools.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jannis Leidel <jannis@leidel.info>
  • Loading branch information
3 people committed Aug 29, 2023
1 parent db8f1c3 commit 34dfb1f
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 2 deletions.
19 changes: 19 additions & 0 deletions news/13034-fix-test-data
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* Update test data to stop triggering security scanners false-positives. (#13034)

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* <news item>
2 changes: 1 addition & 1 deletion tests/conda_env/specs/test_requirements.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ def test_req_file_and_name():
def test_environment():
spec = RequirementsSpec(filename=support_file("requirements.txt"), name="env")
assert isinstance(spec.environment, Environment)
assert spec.environment.dependencies["conda"][0] == "flask==1.1.1"
assert spec.environment.dependencies["conda"][0] == "conda-package-handling==2.2.0"
2 changes: 1 addition & 1 deletion tests/conda_env/support/requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
flask==1.1.1
conda-package-handling==2.2.0

0 comments on commit 34dfb1f

Please sign in to comment.