Speed up find_commands() on WSL (#13035)

On WSL, the entire Windows PATH is inherited, and calling `isfile` (specifically, `os.stat`) across the filesystem boundary is extremely slow. Delaying the check until after pattern matching speeds things up considerably.
conda · Aug 28, 2023 · ae409f8 · ae409f8
1 parent 0038a45
commit ae409f8
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/conda/cli/find_commands.py b/conda/cli/find_commands.py
@@ -70,9 +70,7 @@ def find_commands(include_others=True):
         if not isdir(dir_path):
             continue
         for fn in os.listdir(dir_path):
-            if not isfile(join(dir_path, fn)):
-                continue
             m = pat.match(fn)
-            if m:
+            if m and isfile(join(dir_path, fn)):
                 res.add(m.group(1))
     return tuple(sorted(res))
diff --git a/news/13035-faster-find-commands b/news/13035-faster-find-commands
@@ -0,0 +1,19 @@
+### Enhancements
+
+* <news item>
+
+### Bug fixes
+
+* Fix performance regression of basic commands (e.g., `conda info`) on WSL. (#13035)
+
+### Deprecations
+
+* <news item>
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>