{de,}activate: Remove BSD-ism from sed calls

[mingwandroid]

The -E flag only works on macOS (and some *BSD I guess). In GNU sed, the flag is
-r. These flags turn on 'extended regular expressions'.

Extended regular expressions were only needed in one of the three invocations (the
other case where initially it looked like it serves a purpose removed the : only
to put it back again).

The case that did make use of extended regular expressions is rewritten to use sed
'chaining' instead. I could've added code to determine which sed is being used but
macOS sed does not provide a --version flag and even if it did, calling it twice
would add the overhead of another process invocation.

[mingwandroid]

4.2.14 doesn't work on Linux (was it even tested?!). Please merge this to 4.3.x too.

[mingwandroid]

I cannot use python setup.py install to install my fix for this. Issue filed at #4251

[kalefranz]

Yes, of course it was tested. In several ways by several people. I actually questioned the `-E` flag, but google convinced me it was safe across distros. I must have mis-interpreted. We'll get another release out today.

…

On Jan 10, 2017, at 5:48 AM, Ray Donnelly ***@***.***> wrote: I cannot use python setup.py install to work install my fix for this. Issue filed at #4251 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[mingwandroid]

If this was tested, can you please fix your tests?

[mingwandroid]

I actually questioned the -E flag, but google convinced me it was safe across distros.

sed --help | grep \\-E?

[kalefranz]

your tests fail here. And I'm fixing this, but...

https://www.gnu.org/software/sed/manual/sed.txt

'-E'
'-r'
'--regexp-extended'
Use extended regular expressions rather than basic regular
expressions. Extended regexps are those that 'egrep' accepts; they
can be clearer because they usually have fewer backslashes.
Historically this was a GNU extension, but the '-E' extension has
since been added to the POSIX standard
(http://austingroupbugs.net/view.php?id=528), so use '-E' for
portability. GNU sed has accepted '-E' as an undocumented option
for years, and *BSD seds have accepted '-E' for years as well, but
scripts that use '-E' might not port to other older systems. *Note
Extended regular expressions: ERE syntax.

[mingwandroid]

That conda isn't corrupting PATH isn't something I have any tests for.

Unfortunately 'real' Linuxes all seem to use sed <= 4.2.2. Documentation on GNU's website isn't a substitute for actually checking.

[mingwandroid]

FYI, there has been exactly one release of GNU sed with this feature, sed 4.3, release on 4th Jan 2017.

[kalefranz]

closing in lieu of #4257

[github-actions]

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.