Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual packages to be considered in the solver #10057

Merged
merged 7 commits into from
Aug 6, 2020

Conversation

ericpre
Copy link
Contributor

@ericpre ericpre commented Jul 8, 2020

This is an attempt to be fix #9896 and this issue should also applied to all virtual packages. I don't know if this is the right approach but adding virtual packages to specs_map seems to work!

@ericpre ericpre requested a review from a team as a code owner July 8, 2020 15:53
@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 8, 2020
@jakirkham
Copy link
Member

Thanks Eric! 😀

cc @beckermr

@beckermr
Copy link
Contributor

beckermr commented Jul 8, 2020

Thanks @jakirkham!

@ericpre
Copy link
Contributor Author

ericpre commented Jul 10, 2020

Two tests are failing because of a change in the reported error message changed and is now different from the expected one. Once it is confirmed that the approach is right, I can look into fixing it.

@beckermr
Copy link
Contributor

@jjhelmus @kalefranz @chenghlee any comments here?

@mcg1969
Copy link
Contributor

mcg1969 commented Jul 15, 2020

This looks good but it strikes me we should have a test for this.

@ericpre
Copy link
Contributor Author

ericpre commented Jul 18, 2020

I added a test and adapted two other tests. Appveyor is having hiccups (tests are passing fine but appveyor says Command exited with code 7!) and other than it should be good now.

@jakirkham
Copy link
Member

Would it be possible to get another review of this?

@chenghlee chenghlee added this to the 4.9.0 milestone Aug 5, 2020
@chenghlee chenghlee modified the milestones: 4.9.0, 4.8.4 Aug 6, 2020
@chenghlee chenghlee merged commit c813b73 into conda:master Aug 6, 2020
chenghlee added a commit that referenced this pull request Aug 6, 2020
Add virtual packages to be considered in the solver
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cudatoolkit run constrain on __cuda not used for solve
5 participants