-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtual packages to be considered in the solver #10057
Conversation
Thanks Eric! 😀 cc @beckermr |
Thanks @jakirkham! |
Two tests are failing because of a change in the reported error message changed and is now different from the expected one. Once it is confirmed that the approach is right, I can look into fixing it. |
@jjhelmus @kalefranz @chenghlee any comments here? |
This looks good but it strikes me we should have a test for this. |
I added a test and adapted two other tests. Appveyor is having hiccups (tests are passing fine but appveyor says |
Would it be possible to get another review of this? |
Add virtual packages to be considered in the solver
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
This is an attempt to be fix #9896 and this issue should also applied to all virtual packages. I don't know if this is the right approach but adding virtual packages to
specs_map
seems to work!