logz: Swap from pformat to json.dumps when stringifying json response… #10189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
mingwandroid
force-pushed
the
speed-up-some-logz-json-debug
branch
4 times, most recently
from
2685c82
to
4f80c8f
Compare
angloyna
approved these changes
Aug 25, 2020
When wishing to (debug) print 256 characters from repodata.json from conda-forge, pprint() was observed to take 70 seconds. Changing this to json.dumps() gets it to taking less than a second. Adding indent=2 brings that back up again to a couple of seconds, so to counteract that, we make the assumption that every dict item will result in at least one character being emitted. This seems reasonable to me.
|
Thanks @angloyna |
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s for debug