Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config json output serialization #10194

Merged

Conversation

ydmytryk
Copy link
Contributor

@ydmytryk ydmytryk commented Aug 27, 2020

When user runs a command conda config --json --show-sources it executes with an error. If either safety_checks or path_conflict is present in .condarc.

@ydmytryk ydmytryk requested a review from a team as a code owner August 27, 2020 12:03
@cla-bot
Copy link

cla-bot bot commented Aug 27, 2020

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @ydmytryk. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

Copy link
Contributor

@angloyna angloyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angloyna
Copy link
Contributor

angloyna commented Sep 3, 2020

@cla-bot check

@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 3, 2020
@cla-bot
Copy link

cla-bot bot commented Sep 3, 2020

The cla-bot has been summoned, and re-checked this pull request!

@jjhelmus jjhelmus merged commit bf8ad50 into conda:master Sep 3, 2020
@chenghlee chenghlee added this to the 4.9.0 milestone Sep 14, 2020
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Sep 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants