Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate conda.testing.integration.make_temp_env in favor of conda.testing.tmp_env #12680

Closed
wants to merge 25 commits into from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented May 16, 2023

Description

Continuation of #12592

Straightforward substitutions:

  • tests/cli/test_main_clean.py
  • tests/cli/test_main_list.py
  • tests/gateways/test_connection.py
  • tests/plugins/subcommands/doctor/test_cli.py
  • tests/test_activate.py
  • tests/test_misc.py
  • tests/test_cli.py

Removed unused temporary environment:

  • tests/core/test_subdir_data.py
  • tests/plugins/subcommands/doctor/test_health_checks.py

Refactored into pytest-style:

  • tests/test_export.py
  • tests/test_priority.py

Significant refactor:

  • tests/test_create.py
    • this required a lot of work
    • get tests to run successfully on osx-arm64 (will be valuable when M1 macOS runners become available)

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard self-assigned this May 16, 2023
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 16, 2023
@kenodegard kenodegard mentioned this pull request Jul 17, 2023
3 tasks
@kenodegard
Copy link
Contributor Author

stale, this is being accomplished piecemeal elsewhere

@kenodegard kenodegard closed this Jan 10, 2024
@kenodegard kenodegard deleted the deprecate-make_temp_env branch January 10, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants