Fix pins in test_reorder_channel_priority
#13031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
@jaimergp Did we get more eyes on people with historic knowledge about the classic solver? |
@jezdez - Planning to bring this up in the next conda community call. That said, this (standard or not) expected behaviour should be now implementable via conda/conda-libmamba-solver#270, so this is not a priority I think. |
|
Fixed in conda/conda-libmamba-solver#270 via patched test, but for other reasons. The pin works as in the original test now, so no need for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comes from 14d611a#diff-68cc63c694632f5b92eb4a9942f1cad884cb3b4e75a645ba71d49c249f3859e7R19
This test fails when run with conda-libmamba-solver. I honestly do not understand why it works with conda classic. A pin should constrain what's installable, it doesn't act as a "lock this package to whatever we have installed", afaik. If that's the case, the documentation is wrong, but there are mentions in the changelog where it's implied otherwise.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?