use scandir() in find_commands.py to avoid stat() calls #13070
Conversation
conda-bot
added
the
cla-signed
| if m and isfile(join(dir_path, fn)): | ||
| for entry in os.scandir(dir_path): | ||
| m = pat.match(entry.name) | ||
| if m and entry.is_file(): |
There was a problem hiding this comment.
Should this follow symlinks (the default)? Otherwise:
| if m and entry.is_file(): | |
| if m and entry.is_file(follow_symlinks=False): |
There was a problem hiding this comment.
os.path.isfile() follows symlinks. IMO you would expect to be able to symlink a conda-* command into PATH.
|
@jezdez what if we target main and cherry-pick the fix into the release branch? |
we can, I think it makes more sense (git graph wise) to target the release branch and then merge this back into |
|
We usually do forward ports not backports for release regressions, that's why we have the release branches. Since we can't push to branches directly, cherry-picking doesn't much make it a shortcut. You'd have to open another PR to apply the cherry-picked commit to the release branch. In the forward port scenario, we can do multiple regression fixes in one PR to merge back into main, saving a little time. |
|
FYI the main branch has a pre-existing community contributed fix for this regression. #13035 |
|
superseded by 23.7.4 and #13094 |
Description
This function was especially slow on WSL. In addition to the previous fix, use
scandir()which should grab theis_fileattribute without a separate syscall in most cases.Fixes #13067
See also #13071 which is backported to the 23.7.x branch.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?