Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing tmp_pkgs_dir fixture #13511

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jan 19, 2024

Description

Alternative solution to issue first identified in in conda/conda-libmamba-solver#423 (comment) and then conda/conda-libmamba-solver#426.

Cherry picked from #13162 for easier review (and so this can be merged sooner).

Adds a new fixture tmp_pkgs_dir that mocks context.pkgs_dirs to only return our temporary cache.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard self-assigned this Jan 19, 2024
@kenodegard kenodegard requested a review from a team as a code owner January 19, 2024 19:00
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 19, 2024
Copy link

codspeed-hq bot commented Jan 19, 2024

CodSpeed Performance Report

Merging #13511 will create unknown performance changes

Comparing kenodegard:tmp_pkgs_dir (37c51de) with main (2da9970)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

news/13511-tmp_pkgs_dir Outdated Show resolved Hide resolved
Co-authored-by: Daniel Holth <dholth@anaconda.com>
):
pkg = "zlib"
pkg = "small-executable"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is served by test_recipes_channel, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

@kenodegard kenodegard merged commit 7f79d7c into conda:main Jan 22, 2024
75 checks passed
@kenodegard kenodegard deleted the tmp_pkgs_dir branch January 22, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants