Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard conda remove test #13579

Merged
merged 10 commits into from Feb 12, 2024

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Feb 9, 2024

Description

In conda/conda-libmamba-solver#435, support for the use of wildcards with the remove command is added to the libmamba solver. The accompanying test, however, is not specific to the libmamba solver, but rather can be applied to any solver. In the spirit of moving towards a compliance suite of tests, this PR attempts to upstream the test into conda.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes? Not newsworthy.
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @zklaus.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#875), and ping the bot to refresh the PR.

Copy link

codspeed-hq bot commented Feb 9, 2024

CodSpeed Performance Report

Merging #13579 will create unknown performance changes

Comparing zklaus:upstream-libmamba-solver-test-435 (122b61a) with main (632c198)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

tests/test_solvers.py Outdated Show resolved Hide resolved
tests/test_solvers.py Outdated Show resolved Hide resolved
@zklaus
Copy link
Contributor Author

zklaus commented Feb 9, 2024

Cheers, @kenodegard. I appreciate the input!

@zklaus zklaus force-pushed the upstream-libmamba-solver-test-435 branch from 256829e to b61c248 Compare February 12, 2024 09:47
@dbast
Copy link
Member

dbast commented Feb 12, 2024

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 12, 2024
@zklaus zklaus marked this pull request as ready for review February 12, 2024 12:51
@zklaus zklaus requested a review from a team as a code owner February 12, 2024 12:51
@kenodegard kenodegard changed the title Upstream solver test Add wildcard conda remove test Feb 12, 2024
@kenodegard kenodegard merged commit 29b5d9f into conda:main Feb 12, 2024
75 checks passed
@zklaus zklaus deleted the upstream-libmamba-solver-test-435 branch February 13, 2024 10:00
@jezdez jezdez mentioned this pull request Mar 11, 2024
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants