Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow _ in tokens for better selectability #13646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Mar 4, 2024

Description

Github decided to use _ to delimit a prefix from the token because it's easier to select the token in a browser (e.g. try double-clicking bla-123 vs bla_123 ).

We used to use the pfx_ token on prefix.dev but now we had to switch to pfx- for conda. Would be cool to be able to switch back at some point in the future.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@wolfv wolfv requested a review from a team as a code owner March 4, 2024 10:30
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 4, 2024
Copy link

codspeed-hq bot commented Mar 4, 2024

CodSpeed Performance Report

Merging #13646 will not alter performance

⚠️ No base runs were found

Falling back to comparing wolfv:underscore_token (b631bfc) with main (3e5fcf6)

Summary

✅ 21 untouched benchmarks

@jezdez
Copy link
Member

jezdez commented Mar 5, 2024

@wolfv For posterity’s sake, could you please open a ticket to track this change? In the past, we've had cases where important spec changes were done without much debate or paper trail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

None yet

3 participants