-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a keep_case
flag which ensures that env variables are not uppercased
#13904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #13904 will not alter performanceComparing Summary
|
kenodegard
reviewed
May 8, 2024
pre-commit.ci autofix |
kenodegard
requested changes
May 14, 2024
kenodegard
requested changes
May 20, 2024
kenodegard
reviewed
May 20, 2024
jezdez
requested changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would be even better with a more descriptive name for the config option, keep case of what?
This was referenced May 24, 2024
Closed in favor of #13943. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #13713
At present
conda
converts all environment variables into uppercase.This PR adds a
keep_case
context variable, which allows users to store their environment variables as is.When the
--keep-case
flag is used, environment variables are saved in "preserved case". When the flag is not used variables are saved in upper case (the original conda behavior).Tasks
keep_case
variable to contextkeep_case
isTrue
Checklist - did you ...
news
directory (using the template) for the next release's release notes?