Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow additional characters in prefix names for Windows #13975

Merged
merged 6 commits into from
Jun 19, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jun 12, 2024

Description

Closes #12558

These characters are problematic in Windows activation.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 12, 2024
Copy link

codspeed-hq bot commented Jun 12, 2024

CodSpeed Performance Report

Merging #13975 will not alter performance

Comparing jaimergp:disallowed_characters (2f0ab67) with main (df26cc7)

Summary

✅ 21 untouched benchmarks

@jaimergp jaimergp marked this pull request as ready for review June 14, 2024 08:58
@jaimergp jaimergp requested a review from a team as a code owner June 14, 2024 08:58
@dholth dholth changed the title Disallow extra characters in prefix names for Windows Disallow additional characters in prefix names for Windows Jun 14, 2024
jezdez
jezdez previously approved these changes Jun 17, 2024
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments

news/13975-disallow-characters-windows Outdated Show resolved Hide resolved
Co-authored-by: Jannis Leidel <jannis@leidel.info>
@jezdez jezdez enabled auto-merge (squash) June 19, 2024 08:36
@jezdez jezdez merged commit 82bcb12 into conda:main Jun 19, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Windows: conda cannot activate environments with ! in the name
3 participants