Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conda recipe #2 #2135

Merged
merged 14 commits into from Feb 26, 2016
Merged

Fix conda recipe #2 #2135

merged 14 commits into from Feb 26, 2016

Conversation

kalefranz
Copy link
Contributor

This PR replaces #2100.

@kalefranz kalefranz mentioned this pull request Feb 26, 2016
Closed
@scrutinizer-notifier
Copy link

The inspection completed: 2 updated code elements

kalefranz
kalefranz reviewed Feb 26, 2016
View reviewed changes
conda/cli/main.py

# Note that pip installing conda is not the recommended way for setting up your
# system. The recommended way for setting up a conda system is by installing
# Miniconda, see: http://repo.continuum.io/miniconda/index.html""")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilanschnell Going to need your input here. Why was this ever implemented in the first place? There weren't any tests that failed because of its removal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and merge this. If really need to add this back in, we can do it in a future PR.

@codecov-io
Copy link

Current coverage is 52.39%

Merging #2135 into master will increase coverage by +2.71% as of eac31a1

@@            master   #2135   diff @@
======================================
  Files           49      49       
  Stmts         6511    6505     -6
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           3235    3408   +173
  Partial          0       0       
+ Missed        3276    3097   -179

Review entire Coverage Diff as of eac31a1

Powered by Codecov. Updated on successful CI builds.

kalefranz added a commit that referenced this pull request Feb 26, 2016
@kalefranz
Merge pull request #2135 from conda/pr2100
388baf9 
Fix conda recipe #2
@kalefranz kalefranz merged commit 388baf9 into master Feb 26, 2016
@kalefranz kalefranz deleted the pr2100 branch February 26, 2016 02:13
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kalefranz @scrutinizer-notifier @codecov-io @groutr