Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json output to conda env create/update #9204

Merged
merged 1 commit into from Sep 10, 2019

Conversation

beenje
Copy link
Contributor

@beenje beenje commented Sep 5, 2019

This PR adds json output to the conda env create/update commands.

Some things I'm not sure about:

  1. I had to import conda.exports in conda_env/cli/main.py. Otherwise when it is imported in conda_env/pip_util.py it resets the context.

  2. In my tests, if I keep the same environment name "env-1", each test passes when I run them individually. But they all fail when run together (running pytest -v tests/conda_env/test_cli.py::IntegrationTests). I had to use a different env name for each test. The setUp and tearDown fixtures seem to run properly. At one point I saw that when trying to run pip in the environment env-1/bin/python didn't exist. There was only the env-1/conda-meta directory. Could some files be deleted by the fixture after the test starts?
    Anyway I'm quite sure this is not related to my changes, but an existing issue (in the tests).

@beenje beenje requested a review from a team as a code owner September 5, 2019 14:20
@msarahan
Copy link
Contributor

Thanks @beenje, merging.

@msarahan msarahan merged commit 3f6db11 into conda:master Sep 10, 2019
@beenje beenje deleted the conda_env_json branch September 10, 2019 17:05
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants