Add json output to conda env create/update #9204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds json output to the
conda env create/update
commands.Some things I'm not sure about:
I had to
import conda.exports
inconda_env/cli/main.py
. Otherwise when it is imported inconda_env/pip_util.py
it resets the context.In my tests, if I keep the same environment name "env-1", each test passes when I run them individually. But they all fail when run together (running
pytest -v tests/conda_env/test_cli.py::IntegrationTests
). I had to use a different env name for each test. ThesetUp
andtearDown
fixtures seem to run properly. At one point I saw that when trying to run pip in the environmentenv-1/bin/python
didn't exist. There was only theenv-1/conda-meta
directory. Could some files be deleted by the fixture after the test starts?Anyway I'm quite sure this is not related to my changes, but an existing issue (in the tests).