Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid function redefinition upon resourcing conda.fish #9444

Merged
merged 1 commit into from Nov 15, 2019
Merged

avoid function redefinition upon resourcing conda.fish #9444

merged 1 commit into from Nov 15, 2019

Conversation

jhultman
Copy link

Addresses #9443.

@jhultman jhultman requested a review from a team as a code owner November 15, 2019 17:20
@cla-bot
Copy link

cla-bot bot commented Nov 15, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jacob.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@jhultman
Copy link
Author

Is there no way to verify CLA without requiring contributors to expose private email address? I have github configured to "Block command line pushes that expose my email."

@msarahan
Copy link
Contributor

confirmed CLA. You're good. It's a part-manual process. I had to manually add your name to the special list.

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Nov 15, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jacob.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Nov 15, 2019

The cla-bot has been summoned, and re-checked this pull request!

@msarahan
Copy link
Contributor

whatever. Just ignore it. I'll wait on CI here, but I think your change is fine.

@msarahan
Copy link
Contributor

There are a few failures on master with the output from conda run. Those are not related to your change here and are OK to ignore.

@msarahan msarahan merged commit 62bd8ce into conda:master Nov 15, 2019
@msarahan
Copy link
Contributor

Thanks @jhultman

@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants