Fix running conda activate in multiple processes #8628 #9477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @rulerofthehuns. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
|
Thanks, I confirm that you have signed the CLA and we'll review this pr
soon.
…On Tue, Dec 3, 2019, 08:25 cla-bot[bot] ***@***.***> wrote:
We require contributors to sign our Contributor License Agreement, and we
don't have one on file for @rulerofthehuns
<https://github.com/rulerofthehuns>. In order for us to review and merge
your code, please e-sign the PDF at
https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement.
We then need to manually verify your signature. We will ping the bot to
refresh the PR status when we have confirmed your signature.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#9477?email_source=notifications&email_token=AAAJL6M3OSZC5RQH3PMHIE3QWZT6JA5CNFSM4JUY4CVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFZRM3I#issuecomment-561190509>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJL6IS5CBUVV3MPMDTIV3QWZT6JANCNFSM4JUY4CVA>
.
|
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix for #8628
The cause of the problem:
_conda_activate.bat uses %RANDOM% env var to create a unique temp file.
That isn't very random, details here: https://devblogs.microsoft.com/oldnewthing/20100617-00/?p=13673
When starting multiple processes at the same time, they will try to create and use the same temp file.
The fix:
Create a random directory instead of a file, and check if the creation failed instead of checking the existence of the directory. Only one of the started processes will succeed, the rest will retry.