Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fast frozen solve for conda env update #9511

Merged
merged 1 commit into from Dec 19, 2019
Merged

Implement fast frozen solve for conda env update #9511

merged 1 commit into from Dec 19, 2019

Conversation

osamoylenko
Copy link
Contributor

Implement fast frozen solve for conda env update

In 4.7 release there was introduced the feature of locking down packages that are not involved in the solution, so that the solver’s problem is simpler, and the install commands are run faster.

Thus, conda install has option --freeze-installed (or --no-update-deps) enabled by default with a fallback to the full solve method in case of an unsatisfiable error.

See the corresponding PR: #8620.

In this PR I'm trying to apply the same logic to conda env update command which is effectively rather similar to conda install. This speeds up conda env update by preventing existing packages from unnecessary updating.

I'm not sure whether some additional tests are requiered, as such behavior is already tested in test_install_freezes_env_by_default(), and conda env update uses the same conda.core.solve.Solver as conda install.

@osamoylenko osamoylenko requested a review from a team as a code owner December 15, 2019 11:29
@cla-bot
Copy link

cla-bot bot commented Dec 15, 2019

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @osamoylenko. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

2 similar comments
@cla-bot
Copy link

cla-bot bot commented Dec 15, 2019

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @osamoylenko. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@cla-bot
Copy link

cla-bot bot commented Dec 15, 2019

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @osamoylenko. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@cla-bot
Copy link

cla-bot bot commented Dec 15, 2019

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @osamoylenko. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@msarahan msarahan merged commit 44def1f into conda:master Dec 19, 2019
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants