Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upload path for artifacts #505

Merged
merged 8 commits into from Mar 14, 2022
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Mar 14, 2022

One more fix for #498 , since apparently the artifacts action doesn't support ../xxx relative paths.

Checks

  • Artifacts are uploaded
  • Local constructor is installed in tests
  • Packages can also be uploaded

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 14, 2022
@jaimergp
Copy link
Contributor Author

@jezdez sorry for the extra noise but this should be ready now (and hopefully for good).

@jezdez
Copy link
Member

jezdez commented Mar 14, 2022

There seems to be some overlap with @chrisburr's #503, too

@jaimergp
Copy link
Contributor Author

Is there? I am only touching the workflow file here. It should result in no conflicts.

@chrisburr
Copy link
Contributor

Unfortunately I will be touching them as I've found my PR is failing due to the CI testing the latest release rather than the current branch. (conda install -c local constructor randomly picks between the defaults and local channel)

Though it's no trouble for me to rebase on top of this once it's merged.

@jaimergp
Copy link
Contributor Author

Hm, yes, I am seeing this as well now @chrisburr

@jaimergp
Copy link
Contributor Author

Looks like it's working more reliably now, thanks for the tip!

@jezdez jezdez merged commit 4102cb0 into conda:master Mar 14, 2022
@jezdez jezdez mentioned this pull request Mar 14, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants